Tenative fix for flaky spec #3110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking the flash message after form submission may clarify if this flaky spec failure is caused by something unexpected before submitting the form. Also, this helps in delaying the failing expectation, as the page DOM and HTML should be fully updated by that time.
|
Rerunning our CircleCI workflow several times to see if the problem happens again, Thanks @spaghetticode ! |
kennyadsl
approved these changes
Feb 20, 2019
There was a problem hiding this comment.
Re-run the CI like 3-4 times without a failure. Thanks @spaghetticode!
|
@solidusio/core-team can we have another review here, please? |
tvdeyen
approved these changes
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking the flash message after form submission may clarify if this flaky spec
failure is caused by something unexpected before submitting the form.
Also, this helps in delaying the failing expectation, as the page DOM and
HTML should be fully updated by that time.