Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tenative fix for flaky spec #3110

Merged
merged 1 commit into from Feb 20, 2019

Conversation

Projects
None yet
3 participants
@spaghetticode
Copy link
Member

commented Feb 19, 2019

Checking the flash message after form submission may clarify if this flaky spec
failure is caused by something unexpected before submitting the form.

Also, this helps in delaying the failing expectation, as the page DOM and
HTML should be fully updated by that time.

Tenative fix for flaky spec
Checking the flash message after form submission may clarify if this flaky spec
failure is caused by something unexpected before submitting the form.

Also, this helps in delaying the failing expectation, as the page DOM and
HTML should be fully updated by that time.
@kennyadsl

This comment has been minimized.

Copy link
Member

commented Feb 20, 2019

Rerunning our CircleCI workflow several times to see if the problem happens again, Thanks @spaghetticode !

@kennyadsl
Copy link
Member

left a comment

Re-run the CI like 3-4 times without a failure. Thanks @spaghetticode!

@kennyadsl

This comment has been minimized.

Copy link
Member

commented Feb 20, 2019

@solidusio/core-team can we have another review here, please?

@tvdeyen
Copy link
Member

left a comment

Accessing database values in browser driven feature specs is never a good idea, although pretty widely used... 😞

Thanks for the fix! 👍

@kennyadsl kennyadsl merged commit 6f2bd16 into solidusio:master Feb 20, 2019

9 of 15 checks passed

Header rules - solidus-docs No header rules processed
Details
Header rules - solidus-guides No header rules processed
Details
Pages changed - solidus-docs 294 new files uploaded
Details
Pages changed - solidus-guides 1 new file uploaded
Details
Redirect rules - solidus-docs No redirect rules processed
Details
Redirect rules - solidus-guides No redirect rules processed
Details
Hound No violations found. Woof!
Mixed content - solidus-docs No mixed content detected
Details
Mixed content - solidus-guides No mixed content detected
Details
ci/circleci: mysql Your tests passed on CircleCI!
Details
ci/circleci: mysql_rails51 Your tests passed on CircleCI!
Details
ci/circleci: postgres Your tests passed on CircleCI!
Details
ci/circleci: postgres_rails51 Your tests passed on CircleCI!
Details
netlify/solidus-docs/deploy-preview Deploy preview ready!
Details
netlify/solidus-guides/deploy-preview Deploy preview ready!
Details

@kennyadsl kennyadsl deleted the nebulab:spaghetticode/taxon-flaky-spec branch Feb 20, 2019

@kennyadsl

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.