Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a duplicate method call #3295

Merged
merged 1 commit into from Aug 8, 2019
Merged

Remove a duplicate method call #3295

merged 1 commit into from Aug 8, 2019

Conversation

jacobherrington
Copy link
Contributor

Description

This is another small refactor that replaces a duplicate method call I found. There are lots of tiny refactors around the codebase like this that could be made. 馃槈

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)

spaghetticode
spaghetticode approved these changes Aug 7, 2019
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacobherrington thank you 馃憤

@jacobherrington jacobherrington merged commit a06fe57 into solidusio:master Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaghetticode spaghetticode spaghetticode approved these changes

@ericsaupe ericsaupe ericsaupe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jacobherrington @spaghetticode @ericsaupe