Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace update_attributes with update #3334

Merged
merged 1 commit into from Sep 19, 2019
Merged

Replace update_attributes with update #3334

merged 1 commit into from Sep 19, 2019

Conversation

aldesantis
Copy link
Member

@aldesantis aldesantis commented Sep 16, 2019 •
edited

Description

update_attributes was deprecated in Rails 6 and will be removed in Rails 6.1. This PR replaces all instances of update_attributes with update.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)

ericsaupe
ericsaupe approved these changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@ericsaupe ericsaupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great change!

tvdeyen
tvdeyen reviewed Sep 16, 2019
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think there are some renames that shouldn’t be done.

api/app/controllers/spree/api/shipments_controller.rb Outdated Show resolved Hide resolved
api/app/controllers/spree/api/checkouts_controller.rb Outdated Show resolved Hide resolved
core/app/models/spree/shipment.rb Outdated Show resolved Hide resolved
core/lib/spree/permitted_attributes.rb Outdated Show resolved Hide resolved
@aldesantis aldesantis force-pushed the chore/update-attributes branch 2 times, most recently from e28d44b to 748c13a Compare September 17, 2019 12:51
@aldesantis
Copy link
Member Author

@tvdeyen fixed the ones that were not supposed to be there. :)

@kennyadsl
Copy link
Member

@aldesantis failures seem relevant to the change, can you please take a look when you do have time?

@aldesantis
Copy link
Member Author

@kennyadsl we should be good now! I apologize this took three rounds to get right. 🙏

kennyadsl
kennyadsl approved these changes Sep 18, 2019
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a non-blocking comment, thanks a lot @aldesantis!

core/app/models/spree/shipment.rb Outdated Show resolved Hide resolved
tvdeyen
tvdeyen approved these changes Sep 18, 2019
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks for working on this 🍰

@aldesantis
Replace update_attributes with update
59267da 
update_attributes was deprecated in Rails 6 and will be removed in
Rails 6.1.
@kennyadsl kennyadsl merged commit 18f6ebc into solidusio:master Sep 19, 2019
cpfergus1 added a commit to cpfergus1/solidus_expedited_exchanges that referenced this pull request Jun 2, 2021
@cpfergus1
Replace update_attributes with update [#3334](solidusio/solidus#3334)
af72f50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdeyen tvdeyen tvdeyen approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

@ericsaupe ericsaupe ericsaupe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aldesantis @kennyadsl @tvdeyen @ericsaupe