Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Coupon Code Field's Length in Firefox #3387

Merged
merged 1 commit into from
Oct 23, 2019
Merged

Fix Coupon Code Field's Length in Firefox #3387

merged 1 commit into from
Oct 23, 2019

Conversation

amree
Copy link
Contributor

@amree amree commented Oct 19, 2019

Description

The coupon code styling seems to be broken in Firefox compared to Chrome and Safari. These changes should ensure it fits nicely and consistent between browsers.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)

Screenshots

Before (Firefox)

image

After

Chrome Firefox Safari
chrome firefox safari

@amree amree changed the title Fix Coupon Code Fields' Length in Firefox Fix Coupon Code Field's Length in Firefox Oct 19, 2019
@amree
Fix Coupon Code Field's Length in Firefox
18e30cf 
The coupon code styling seems to be broken in Firefox compared to Chrome
and Safari. These changes should ensure it fits nicely and consistent
between browsers.
jacobherrington
jacobherrington approved these changes Oct 20, 2019
View reviewed changes
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This has annoyed me for a while, but I've never fixed it!

Thanks for submitting a PR! 👍

spaghetticode
spaghetticode approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amree thank you 👍

@jacobherrington jacobherrington merged commit 93df195 into solidusio:master Oct 23, 2019
@amree amree deleted the fix-coupon-code-in-ff branch May 9, 2020 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaghetticode spaghetticode spaghetticode approved these changes

@jacobherrington jacobherrington jacobherrington approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amree @spaghetticode @jacobherrington