Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin] Fix bug for billing address state value not changing with customer #3435

Merged
merged 2 commits into from Nov 25, 2019
Merged

[Admin] Fix bug for billing address state value not changing with customer #3435

merged 2 commits into from Nov 25, 2019

Conversation

spaghetticode
Copy link
Member

Fixes #3434

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

@spaghetticode spaghetticode added type:bug Error, flaw or fault changelog:solidus_backend Changes to the solidus_backend gem labels Nov 21, 2019
@spaghetticode
Admin new-order form: customer with textual state bugfix
1bf4279 
When creating a new order from the backend, when the admin user changes
customer using the autocomplete field and the new customer has only a
textual state, the bill address shown in page should show the expected
textual state.
@spaghetticode
Admin new-order form: customer state change bugfix
1fef20f 
When creating a new order from the backend, when the admin user selects
a different customer from the autocomplete field and the customer has
same country but different state from the customer that was selected
before, the bill address state select value should show the new customer
state.
kennyadsl
kennyadsl approved these changes Nov 22, 2019
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Andrea!

jacobherrington
jacobherrington approved these changes Nov 23, 2019
View reviewed changes
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for the tests 👍

@kennyadsl kennyadsl merged commit eb61fff into solidusio:master Nov 25, 2019
@kennyadsl kennyadsl deleted the spaghetticode/order-state-bug branch November 25, 2019 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyadsl kennyadsl kennyadsl approved these changes

@jacobherrington jacobherrington jacobherrington approved these changes

Assignees
No one assigned
Labels
changelog:solidus_backend Changes to the solidus_backend gem type:bug Error, flaw or fault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Admin] new-order form - billing address state value should change with customer
3 participants
@spaghetticode @kennyadsl @jacobherrington