Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Spree.routes with Spree.pathFor #3605

Merged
merged 1 commit into from May 26, 2020
Merged

Replace Spree.routes with Spree.pathFor #3605

merged 1 commit into from May 26, 2020

Commits on May 22, 2020

  1. Replace Spree.routes with Spree.pathFor 

    This PR replaces all instances of Spree.routes with Spree.pathFor. Spree.routes still
exists, we're just preferring to use Spree.pathFor per solidusio#3405.

It uses Proxy to issue a deprecation warning, however if Proxy isn't defined (in older
browsers like IE) will just return the routes without deprecation. Hopefully the developer
of the app will have something newer than IE, if they don't I imagine they have
bigger problems than JS route deprecations 馃槵

Also adds Proxy to ESlint so it doesn't trigger the no-undef rule.
    @seand7565
    seand7565 committed May 22, 2020
    Configuration menu
    Copy the full SHA
    5d55e10 View commit details
    Browse the repository at this point in the history