Fixing mark default billing address #3634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User.mark_default_bill_address was not working, It was calling mark_default method with two params, but the second one had to be a named param.
jarednorman
approved these changes
May 24, 2020
aldesantis
approved these changes
May 25, 2020
spaghetticode
approved these changes
May 27, 2020
There was a problem hiding this comment.
@softr8 thanks for the fix 👍
I think this PR is an interesting use-case that shows why doubles can be dangerous when testing ActiveRecord models and their associations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User.mark_default_bill_address was not working, It was calling
mark_default method with two params, but the second one
had to be a named param.
Checklist: