Commits on Jun 3, 2020

1. Add factory_bot lint test to core …

   Adds a test that lints FactoryBot. Also makes changes to two tests to
   conform to the lint - store_credit_event_factory needs to have an
   action, even if the action is replaced with one of the sub factories.
   store_credit_reason_factory tripped the linter because of a uniqueness
   contraint for the name - should not come up in normal testing, but I
   added a sequencer to account for it in the linter anyway.
   
   The linter ignores just one factory - customer_return_without_return_items
   this factory is intentionally invalid (see:
   /core/spec/lib/spree/core/testing_support/factories/customer_return_factory_spec.rb#L37
   )

   

   seand7565 committed Jun 3, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 92a5e3b
   • Browse repository at this point

   Copy the full SHA

   92a5e3b View commit details

   Browse the repository at this point in the history