Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preference for phone validation #3685

Merged
merged 2 commits into from Oct 3, 2020

Conversation

seand7565
Copy link
Contributor

@seand7565 seand7565 commented Jun 26, 2020

Description
Adds phone number validation preference so users can easily indicate
whether or not they want to require phone numbers for addresses.
Ref: #3679

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

core/app/models/spree/address.rb Show resolved Hide resolved
core/app/models/spree/address.rb Outdated Show resolved Hide resolved
core/app/models/spree/address.rb Outdated Show resolved Hide resolved
core/app/models/spree/address.rb Outdated Show resolved Hide resolved
@seand7565 seand7565 force-pushed the remove_phone_validation branch 2 times, most recently from 92fe4b3 to 436514d Compare July 27, 2020 19:58
Copy link
Member

@jarednorman jarednorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think most stores are going to want to keep the phone requirement, aren't they? Pretty much every ecommerce experience I've ever used has, if for nothing else then for support purposes. I don't think we should change the default here, though I'm all for making it configurable if that's something people want to configure.

@seand7565
Copy link
Contributor Author

I've had the opposite experience - The stores I've worked with prefer not to collect phone numbers (more fields on checkout -> lower conversion, at least in theory) and personally it's something that I'd prefer not to give out as a consumer, especially if there's no obvious reason for it - it just feels like data collection for the sake of data collection.

I'd like Solidus to be less opinionated about what is and isn't required during checkout - IMO anything not immediately necessary to pay for and ship the order should be optional by default.

@jarednorman
Copy link
Member

All fair points. I wish we had a way to gather info about what stores needed more generally. I can only speak to the fact that all of the stores we're currently managing (five or so) require phone and will have to change this setting from the new default if we adopt this. It's obviously only an extremely minor inconvenience, but it makes me second-guess whether it's the right call or whether this is going to be a minor inconvenience to quite a lot of stores.

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also like to ask less info to users during checkout but I think it's better to keep the old behavior as default without real data to confirm our ideas.

core/lib/spree/app_configuration.rb Outdated Show resolved Hide resolved
Adds phone number validation preference so users can easily indicate
whether or not they want to require phone numbers for addresses.
Ref: solidusio#3679
The `require_zipcode?` method does not check for validity, only presence.
@seand7565 seand7565 changed the title Set phone validation to false Add preference for phone validation Oct 1, 2020
@aldesantis aldesantis merged commit a17109b into solidusio:master Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants