[Admin] Fix Square Logos appearance #3702
Merged
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarednorman
requested changes
Jul 12, 2020
backend/app/assets/stylesheets/spree/backend/components/_navigation.scss
Outdated
Show resolved
Hide resolved
jarednorman
requested changes
Jul 14, 2020
michaelmichael
force-pushed
the
fix-square-logos-in-admin-3692
branch
from
11e704e
to
02b3182
Compare
|
Ok, squashed into a single commit. |
jarednorman
approved these changes
Jul 15, 2020
spaghetticode
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ref #3692
This just adds an explicit height to the
.brand-linkdiv in admin. This height is controlled by the$main-header-heightvariable. Then it sets the image to have a max-width/height of 100%. It should prevent logos of any size or aspect ratio from overflowing and preventing access to the ui. See square, tall, and wide logos below:Checklist: