Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix admin portugues locale #4107

Merged
merged 1 commit into from Jun 29, 2021

Conversation

ruipbarata
Copy link
Contributor

Description
When changing the admin backend language to Português (PT), it will look for the file select2_locale_pt-PT.js that does not exist.

Outpus the error
The asset "solidus_admin/select2_locales/select2_locale_pt.js" is not present in the asset pipeline.

To Reproduce:

  1. Open the admin backend
  2. Select Português (PT) in the language selection menu at the bottom right

It is looking for the right file. The file select2_locale_pt-PT.js must be renamed to select2_locale_pt.js and the two references "pt-PT" must be changed to "pt"

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

When changing the admin backend language to Português (PT), it will look for the file select2_locale_pt-PT.js that does not exist.

To Reproduce:
1. Open the admin backend
2. Select Português (PT) in the language selection menu at the bottom right

It is looking for the right file. The file select2_locale_pt-PT.js must be renamed to select2_locale_pt.js and the two references "pt-PT" must be changed to "pt"
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kennyadsl kennyadsl merged commit 765f9a4 into solidusio:master Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants