Remove deprecated order updater promotions code #4890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now do all of this stuff in the configurable promotion adjuster class.
7 tasks
github-actions
bot
added
the
changelog:solidus_core
kennyadsl
added
the
release:major
adammathys
approved these changes
Jan 31, 2023
Codecov Report
@@ Coverage Diff @@
## master #4890 +/- ##
==========================================
+ Coverage 86.25% 86.29% +0.04%
==========================================
Files 577 577
Lines 14678 14665 -13
==========================================
- Hits 12660 12655 -5
+ Misses 2018 2010 -8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a followup to #4460. As part of the transition to using the configurable order adjuster and removing some of the knowledge around promotions from the order updater, we were still updating the order's promo total in
#update_adjustment_total. This removes the deprecated methods and the line that supports them.This is for Solidus 4.0.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
I have documented new code with YARD.The following are not always needed (
cross them outif they are not):I have added automated tests to cover my changes.I have attached screenshots to demo visual changes.I have opened a PR to update the guides.I have updated the README to account for my changes.