Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Paperclip Adapter #5100

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Deprecate Paperclip Adapter #5100

wants to merge 4 commits into from

Commits on Jun 5, 2023

  1. Add solidus:paperclip_adapter:install generator 

    This generator allows incorporating the paperclip adapter into
the host application, in order to remove support for it from core.

This generator does two things:

1. Copy the Image and Taxon Paperclip adapters into the host
   application;
2. Set the right configurations in the spree.rb (path configurable)
   initializer in order to use the newly created files.
    @kennyadsl
    kennyadsl committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    b6bf32d View commit details
    Browse the repository at this point in the history

  2. Deprecate using Paperclip as Image/Taxon attachment adapter 

    We are also providing a message with instructions for who wants
to keep using Paperclip.

We are silencing deprecation warnings when setting the deprecated
configuration in the CI. This will allow us to keep testing if our
code still works with the deprecated adapter.
    @kennyadsl
    kennyadsl committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    aef8f5a View commit details
    Browse the repository at this point in the history

  3. Stop using the paperclip adapter in the main installer 

    When `--active_storage=false` is used in for the main installer
we can use the new generator to copy the adapter in the host
application.
    @kennyadsl
    kennyadsl committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    f1000cb View commit details
    Browse the repository at this point in the history

  4. Incorporate Paperclip adapter in DummyApp 

    Only when we are testing against Paperclip in the build matrix.
    @kennyadsl
    kennyadsl committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    7442e93 View commit details
    Browse the repository at this point in the history