Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v4.2] Restore using MenuItem#sections for matching paths #5409

Merged
merged 2 commits into from
Oct 3, 2023
Merged

[v4.2] Restore using MenuItem#sections for matching paths #5409

merged 2 commits into from
Oct 3, 2023

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Oct 3, 2023

Backport

This will backport the following commits from main to v4.2:

Questions ?

Please refer to the Backport tool documentation

@elia
Fix MenuItem#match_path? specs subject definitions
44f2172 
(cherry picked from commit d9bc849)
@elia
Include MenuItem#sections while matching path
0f17bdf 
Using sections for matching the path was originally done inside the
#tab helper, when the responsibility was moved to MenuItem this use-
case was lost. Not anymore.

(cherry picked from commit d6cb238)
@github-actions github-actions bot requested a review from a team as a code owner October 3, 2023 11:52
@github-actions github-actions bot added the changelog:solidus_backend Changes to the solidus_backend gem label Oct 3, 2023
@github-actions github-actions bot mentioned this pull request Oct 3, 2023
Merged
3 tasks
@elia elia changed the title [v4.2] Restore using `MenuItem#sections` for matching paths [v4.2] Restore using MenuItem#sections for matching paths Oct 3, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023 •
edited

Codecov Report

Merging #5409 (0f17bdf) into v4.2 (4233a67) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             v4.2    #5409   +/-   ##
=======================================
  Coverage   88.86%   88.86%           
=======================================
  Files         607      607           
  Lines       14747    14747           
=======================================
  Hits        13105    13105           
  Misses       1642     1642
Files Coverage Δ
...ckend/lib/spree/backend_configuration/menu_item.rb 98.18% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia elia merged commit e47bfae into v4.2 Oct 3, 2023
9 checks passed
@elia elia deleted the backport/v4.2/pr-5406 branch October 3, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyadsl kennyadsl Awaiting requested review from kennyadsl

Assignees

@elia elia

Labels
changelog:solidus_backend Changes to the solidus_backend gem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@elia