Use git ls-files for the gemspec file listing #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the new image factory doesn't work in projects because the image isn't being bundled into the gem. This ensures we're bundling all the files in the repo, and it makes it harder to accidentally include files in a release. One change is that this will include specs in the gem where it didn't before, which IMO is fine.
|
👍 |
1 similar comment
|
👍 |
cbrunsdon
added a commit
that referenced
this pull request
Nov 30, 2015
Use git ls-files for the gemspec file listing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the new image factory doesn't work in projects including the gem because the image isn't being bundled into the gem.
This ensures we're bundling all the files in the repo, and it makes it harder to accidentally include files we don't want in a release. One change is that this will include specs in the gem where it didn't before, which IMO is fine.
api project's gemspec wasn't changed here because it already used
git ls-filesFixes #543