Leaving image files open is a bad idea when seeding image data #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
punjab
changed the title
|
Can you squash this into one commit for us? Otherwise I'm 👍 on this. Thanks! |
Fixed no implicit conversion of Hash into String error
|
@magnusvk Done! Squashed the two commits into one. Glad to contribute my first commit to solidus. Hopefully many more to come. |
|
👍 |
|
👍 from me too, thanks @punjab. Taking Magnus' pre-squash thumbs up as well |
cbrunsdon
added a commit
that referenced
this pull request
Nov 30, 2015
Leaving image files open is a bad idea when seeding image data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When seeding data, the previous setup returned the following error sometimes.
The issue can be tracked back in other applications when using paperclip, if not properly closing the opened files. thoughtbot/paperclip#862