Solidus Admin: Import legacy items after routes are generated #5612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5612 +/- ##
=======================================
Coverage 88.57% 88.57%
=======================================
Files 685 685
Lines 16405 16405
=======================================
Hits 14531 14531
Misses 1874 1874 ☔ View full report in Codecov by Sentry. |
When importing legacy menu items into the new storefront's API, the `import_menu_items_from_backend` method will try reading the legacy menu item's paths. Those path might be defined in lambdas referencing route helpers, but those route helper are only available after the application's routes have been fully loaded. I understand this is somewhat kludgy, but on the upside: It works.
mamhoff
force-pushed
the
import-legacy-menu-later
branch
from
0ce9288
to
af57898
Compare
tvdeyen
reviewed
Jan 30, 2024
There was a problem hiding this comment.
Thanks, but I really would like us to fix this where the issue actually happens. I looked into it once and it seems to happen in the admin configuration. Although the route resolution should happen later in the view layer where the route lambdas get actually called, but I haven't found a good solution yet.
|
Thanks, Martin. May I ask what is the actual problem here? I understand the technicalities but not what's the final result of this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When importing legacy menu items into the new storefront's API, the
import_menu_items_from_backendmethod will try reading the legacy menu item's paths. Those path might be defined in lambdas referencing route helpers, but those route helper are only available after the application's routes have been fully loaded.I understand this is somewhat kludgy, but on the upside: It works.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: