[v4.3] Fix search by variant on stock items #5663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Before we fix this bug, we should reproduce it in a feature spec. Co-authored-by: An Stewart <andrew@super.gd> Co-authored-by: Adam Mueller <adam@super.gd> (cherry picked from commit 2409038)
This "fixes" the variant scope issue but I'm not sure it's the solution we want. I suppose it depends if ordering by sku is important here. Co-authored-by: An Stewart <andrew@super.gd> (cherry picked from commit c4bd75a)
github-actions
bot
added
the
changelog:solidus_backend
3 tasks
adammathys
approved these changes
Feb 14, 2024
|
Flaky spec not related to change. Reran build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintov4.3:Questions ?
Please refer to the Backport tool documentation