Move promotion backend controllers and views to legacy_promotions #5685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog:solidus_backend
mamhoff
force-pushed
the
move-promotion-admin
branch
from
5c4059a
to
ad5e56e
Compare
github-actions
bot
added
the
changelog:solidus_core
mamhoff
force-pushed
the
move-promotion-admin
branch
2 times, most recently
from
f3cac10
to
53afa71
Compare
mamhoff
changed the title
mamhoff
force-pushed
the
move-promotion-admin
branch
from
53afa71
to
880b972
Compare
mamhoff
force-pushed
the
move-promotion-admin
branch
from
880b972
to
373a442
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5685 +/- ##
=======================================
Coverage 88.90% 88.91%
=======================================
Files 700 700
Lines 16642 16649 +7
=======================================
+ Hits 14796 14803 +7
Misses 1846 1846 ☔ View full report in Codecov by Sentry. |
mamhoff
force-pushed
the
move-promotion-admin
branch
2 times, most recently
from
b1ff45a
to
c7ebe82
Compare
mamhoff
force-pushed
the
move-promotion-admin
branch
from
c7ebe82
to
01cc257
Compare
In order to move the promotion controller specs, we need the controller-specific helpers in our `spec/rails_helper.rb` file.
We want to move some backend functionality here, so we need solidus_backend.
The routes for the promotion admin are moving into solidus_legacy_promotions, but they are needed in solidus_admin.
The promotion routes will move to legacy_promotions.
We won't have the admin/promotions route available in backend for much longer.
Also moves all the promotion-related translations in the `spree` namespace that are used within these controllers and views.
Note that the promotion rules helper does not live under app/helpers/spree/admin, but the promotion helper does. Keeping it just the same.
mamhoff
force-pushed
the
move-promotion-admin
branch
from
01cc257
to
44e01f5
Compare
kennyadsl
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This moves the promotion admin to the legacy_promotions gem. Admin means: The admin controllers and views for promotions, promotion actions, promotion rules, and promotion calculators. It also moves the translations used in these controllers.
This only tackles the backend controllers, not the ones in
solidus_admin.This also does not tackle the backend Javascript related to promotions, because that's another slightly complicated PR. Because we depend on
solidus_backendfromsolidus_legacy_promotionsnow, these JS files are still around and working within the admin for now.Note that I'm moving the specs first, and then the implementation. I do that in order to keep every commit along the way green.
Best reviewed commit by commit. I promise this is just moving things.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: