[Admin] adding new shipping category #5718
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog:solidus_core
|
Thanks @loicginoux! I created #5720 to attach to this PR, thanks again! |
loicginoux
changed the title
loicginoux
changed the title
5 tasks
|
Not sure about the failing linter CI step. Should I look into it or is it something with the CI ? The error does not look like specific to this PR... |
|
The error seems to be related to ESLint in the CI. I you want to take a look at it with another PR, you are more than welcome, thanks Loic! |
3 tasks
loicginoux
force-pushed
the
feature/admin-shipping-category
branch
from
e762007
to
5cc263b
Compare
Now that new admin allow for searching them, we had to allow name attrribute to be searchable via ransack
loicginoux
force-pushed
the
feature/admin-shipping-category
branch
from
5cc263b
to
55ec39e
Compare
|
I just rebased branch from main after the linting CI error has been fixed in #5721. CI should be green here after that. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5718 +/- ##
==========================================
+ Coverage 88.84% 88.86% +0.02%
==========================================
Files 704 705 +1
Lines 16757 16789 +32
==========================================
+ Hits 14887 14919 +32
Misses 1870 1870 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the creation of new shipping categories to the new admin interface.
It follows the same kind of work done for Tax categories in #5674
There is no issue but a project item that I cannot move or comment, probably due to permission issues. https://github.com/orgs/solidusio/projects/12/views/1?filterQuery=xs&pane=issue&itemId=52590587
I also fixed searching shipping categories. This was a feature not present on old admin and by introducing new UI, and capability to search them, it was missing a ransack config to allow searching them by name.
Screen.Recording.2024-04-10.at.13.00.01.mov
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: