This repository has been archived by the owner on Sep 12, 2019. It is now read-only.
Update solidus_avatax for Solidus >= 1.1.0 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spree_adjustments.state has been moved to spree_adjustments.finalized in Solidus >= 1.1.0
jordan-brough
changed the title
jordan-brough
changed the title
Address is immutable in Solidus >= 1.1.0 so this code is useless and the specs break when they try to mutate addresses.
jordan-brough
force-pushed
the
handle-adjustment-schema-update
branch
from
655fec9
to
b79d0e8
Compare
"confirm" is now truly a required step in Solidus 1.1.0
jordan-brough
force-pushed
the
handle-adjustment-schema-update
branch
from
b79d0e8
to
696bb70
Compare
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple things that need to be brought up to date here for Solidus >= 1.1.0
See solidusio/solidus#279
We could alternatively replace the direct-table-accesses (e.g.
update_all) so that they don't blow up, and we could have a bunch of checks scattered around to decide whether to setstateorfinalized(to avoid blowing up in the old code and avoid generating deprecation warnings all the time in the new Solidus) but that didn't seem worth it in this case. Happy to hear other opinions though.The address_decorator logic is now useless and the specs are also failing when they try to mutate an address
Some specs that try to transition from payment -> complete are failing.