Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt sandbox script to solidus 4 #212

Merged

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Jun 16, 2023

Summary

The automatically generated bin/sandbox script does not work with current Solidus any longer. This upgrades the script to work with (at least) Solidus 4.

It also provides a Rake task to help you obtain this script in existing extensions. From the root of your extension, run

bin/rake extension:upgrade_binstubs

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 馃摉 I have updated the README to account for my changes.

@mergify mergify bot added the needs changelog label Needs a label to determine the type of change. label Jun 16, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 16, 2023

It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:

  • bug for bugfixes.
  • enhancement for new features and improvements.
  • documentation for documentation changes.
  • security for security patches.
  • removed for feature removals.
  • infrastructure for internal changes that should not go in the changelog.

Additionally, the maintainer may also want to add one of the following:

  • breaking for breaking changes.
  • deprecated for feature deprecations.

Once the correct labels have been set, simply remove the needs changelog label label from this PR so I can merge it.

@mamhoff mamhoff force-pushed the adapt-sandbox-script-to-solidus-4 branch 2 times, most recently from ddc642e to 244e0d9 Compare June 19, 2023 10:11
The sandbox script has been updated in core, and this takes the changes
from there and adds them to the bin/sandbox template.
@mamhoff mamhoff force-pushed the adapt-sandbox-script-to-solidus-4 branch from 244e0d9 to 0b72258 Compare June 20, 2023 08:30
@kennyadsl kennyadsl added bug Describes or fixes a bug. and removed needs changelog label Needs a label to determine the type of change. labels Jun 22, 2023
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Martin!

@kennyadsl kennyadsl merged commit a894644 into solidusio:master Jun 22, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Describes or fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants