Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Solidus 2.x deprecations #98

Closed
6 tasks done
kennyadsl opened this issue Jan 15, 2021 · 0 comments · Fixed by #99
Closed
6 tasks done

Remove Solidus 2.x deprecations #98

kennyadsl opened this issue Jan 15, 2021 · 0 comments · Fixed by #99
Assignees

Comments

@kennyadsl
Copy link
Member

kennyadsl commented Jan 15, 2021

  • Add a method in solidus_support that understands if name should be used combined or not taking into account the Solidus version used and the related preference's value Add a method to check if combined address name is being used  solidus_support#58
  • Release a new version of Solidus Support
  • Remove deprecation warnings related to the address' name combined.
  • DEPRECATION WARNING: From Solidus v3.0 onwards, #perform! will need to be explicitly called when creating new refunds. Please, change your code from: Spree::Refund.create(your: attributes) to: Spree::Refund.create(your: attributes, perform_after_create: false).perform! (called from try_void at ~/Code/solidusio/solidus_stripe/app/models/spree/payment_method/stripe_credit_card.rb:90)
  • DEPRECATION WARNING: Please, do not use Spree::Refund @response anymore, use Spree::Refund#perform_response Args: [] (called from record_response at ~/.asdf/installs/ruby/2.7.1/lib/ruby/gems/2.7.0/bundler/gems/solidus-ed88ebc464d1/core/app/models/spree/payment/processing.rb:206)
  • DEPRECATION WARNING: Please, do not use Spree::Refund @response anymore, use Spree::Refund#perform_response Args: [] (called from handle_void_response at /~/.asdf/installs/ruby/2.7.1/lib/ruby/gems/2.7.0/bundler/gems/solidus-ed88ebc464d1/core/app/models/spree/payment/processing.rb:132)

cc @rainerdema

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant