Remove Solidus 2.x deprecation to allow 3.0 usage #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
force-pushed
the
kennyadsl+rainerdema/fix-deprecations-3.0
branch
7 times, most recently
from
07ca3ed
to
ad35ebf
Compare
kennyadsl
changed the title
This is using the new SolidusSupport helper method to determine when using one or the other version. Co-authored-by: Rainer Dema <rainerdema@users.noreply.github.com>
kennyadsl
force-pushed
the
kennyadsl+rainerdema/fix-deprecations-3.0
branch
from
ad35ebf
to
60fd59e
Compare
kennyadsl
force-pushed
the
kennyadsl+rainerdema/fix-deprecations-3.0
branch
2 times, most recently
from
ecbd45c
to
85f82e8
Compare
After solidusio/solidus#3641 it's requested to create and perform refunds in two different operations. This commit aligns the code to the new standard. Co-authored-by: Rainer Dema <rainerdema@users.noreply.github.com>
kennyadsl
force-pushed
the
kennyadsl+rainerdema/fix-deprecations-3.0
branch
from
85f82e8
to
aad2ed6
Compare
spaghetticode
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #98 by removing all the deprecation warnings making this gem compatible with Solidus 3.0.
Blocked by #97 and solidusio/solidus#3908.
Co-authored-by: @rainerdema