Fix how we compare gem versions to determine new gateway code usage #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
force-pushed
the
fix-version-comparing
branch
from
1b26e35
to
b510495
Compare
This commit fixes how we are comparing gem versions to understand if we need to use the new payment gateway related class as parents of our extensions' classes. It also fixes the logic into the payment_method_parent_class which was wrong.
kennyadsl
force-pushed
the
fix-version-comparing
branch
from
b510495
to
0b13a0f
Compare
gmacdougall
approved these changes
Oct 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes how we are comparing gem versions to understand if we need to use the new payment gateway related class as parents of our extensions' classes.
It also fixes the logic into the payment_method_parent_class which was wrong.