Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capybara-screenshot dependency #23

Merged

Conversation

spaghetticode
Copy link
Member

@spaghetticode spaghetticode commented Aug 2, 2019

Although the gem was not explicitly listed as a code dependecy it is actually
required in file extension/feature_helper.rb:

  require 'capybara-screenshot/rspec'

So, gems that require 'extension/feature_helper.rb' can now avoid to explicitly list capybara-screenshot among their dependencies.

@spaghetticode spaghetticode self-assigned this Aug 2, 2019
@spaghetticode spaghetticode force-pushed the spaghetticode/capybara-screenshot-gem branch from 771b60f to 02ffd70 Compare August 2, 2019 14:02
Although the gem was not explicitly listed as a code dependecy it is actually
required in file `extension/feature_helper.rb`:

  require 'capybara-screenshot/rspec'
Copy link

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good catch!

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kennyadsl kennyadsl merged commit 3cc1c84 into solidusio:master Aug 8, 2019
@kennyadsl kennyadsl deleted the spaghetticode/capybara-screenshot-gem branch August 8, 2019 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants