Remove support for testing and extensions #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinasMazar
force-pushed
the
mm/extract-dev-tools
branch
from
758d407
to
cf814f4
Compare
MinasMazar
pushed a commit
to solidusio/solidus_dev_support
that referenced
this pull request
Dec 6, 2019
It was added in `solidus_support` with [this PR](solidus-support-pr) and it has been extracted with [this PR](extract-pr). Ref. #13 [solidus-support-pr]: solidusio/solidus_support#27 [extract-pr]: solidusio/solidus_support#28
MinasMazar
pushed a commit
to solidusio/solidus_dev_support
that referenced
this pull request
Dec 6, 2019
It was added in `solidus_support` with [this PR](solidus-support-pr) and it has been extracted with [this PR](extract-pr). Ref. #13 [solidus-support-pr]: solidusio/solidus_support#27 [extract-pr]: solidusio/solidus_support#28
MinasMazar
pushed a commit
to solidusio/solidus_dev_support
that referenced
this pull request
Dec 6, 2019
It was added in `solidus_support` with [this PR](solidus-support-pr) and will be extracted with [this PR](extract-pr). Ref. #13 [solidus-support-pr]: solidusio/solidus_support#27 [extract-pr]: solidusio/solidus_support#28
Some things of this gem will be moved to [solidus_extension_dev_tools](dev_tools) we should remove and/or deprecate those within solidus_support to avoid confusion and have a clear update path for extension maintainers. Extracted: + feature/spec helpers + coverage support + preferences stub (`stub_spree_preferences`) + extension decorator (`SolidusSupport::EngineExtensions::Decorators`) Ref. solidusio/solidus_dev_support#13 [dev_tool]: https://github.com/solidusio-contrib/solidus_extension_dev_tools
MinasMazar
force-pushed
the
mm/extract-dev-tools
branch
from
cf814f4
to
1ee39a7
Compare
aldesantis
approved these changes
Dec 13, 2019
|
Looking good @MinasMazar, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some things of this gem will be moved to solidus_extension_dev_tools we should remove and/or deprecate those within solidus_support to avoid confusion and have a clear update path for extension maintainers.
Extracted:
stub_spree_preferences)extension decorator (SolidusSupport::EngineExtensions::Decorators)Ref. solidusio/solidus_dev_support#13
This PR also continue what started in #25 (that should be closed)