Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant solidus_core dev dependency #50

Merged
merged 1 commit into from
Aug 10, 2020

Conversation

brchristian
Copy link
Contributor

When I was testing the 0.5.1 release on my local machine, running bundle install showed the following warning:

Your Gemfile lists the gem solidus_core (>= 0) more than once.
You should probably keep only one of them.
Remove any duplicate entries and specify the gem only once.
While it's not a problem now, it could cause errors if you change the version of one of them later.

It looks like if we already require solidus_core in the Gemfile here:

gem 'solidus_core', github: 'solidusio/solidus', branch: branch

Then we don't need to also include it as a development dependency in solidus_support.gemspec.

Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brchristian thank you 👍

@spaghetticode spaghetticode merged commit 1f2b80b into solidusio:master Aug 10, 2020
@brchristian brchristian deleted the patch-1 branch August 10, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants