1.29.2 (#18)

* build(deps): bump distroless/base-nossl-debian12 from `51ab103` to `49edf70` in /ci (envoyproxy#32348) build(deps): bump distroless/base-nossl-debian12 in /ci Bumps distroless/base-nossl-debian12 from `51ab103` to `49edf70`. --- updated-dependencies: - dependency-name: distroless/base-nossl-debian12 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Ryan Northey <ryan@synca.io> * build(deps): bump distroless/base-nossl-debian12 from `49edf70` to `0e777c6` in /ci (envoyproxy#32576) build(deps): bump distroless/base-nossl-debian12 in /ci Bumps distroless/base-nossl-debian12 from `49edf70` to `0e777c6`. --- updated-dependencies: - dependency-name: distroless/base-nossl-debian12 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Ryan Northey <ryan@synca.io> * populate histogram summary sample sum Signed-off-by: Sebastian Schepens <sebastian.schepens@mercadolibre.com> * http2: Switch the value of envoy.reloadable_features.http2_use_oghttp2 to false (envoyproxy#32751) http2: Switch the value of envoy.reloadable_features.http2_use_oghttp2 to false A number of users have reported issues with oghttp2 including envoyproxy#32611 and envoyproxy#32401 so reverting this flag seems wise. Signed-off-by: Ryan Hamilton <rch@google.com> * repo: Release v1.29.2 **Summary of changes**: - Revert default codec to nghttp2 as a number of users have reported issues with oghttp2 including envoyproxy#32611 and envoyproxy#32401 - Assorted minor fixes **Docker images**: https://hub.docker.com/r/envoyproxy/envoy/tags?page=1&name=v1.29.2 **Docs**: https://www.envoyproxy.io/docs/envoy/v1.29.2/ **Release notes**: https://www.envoyproxy.io/docs/envoy/v1.29.2/version_history/v1.29/v1.29.2 **Full changelog**: envoyproxy/envoy@v1.29.1...v1.29.2 Signed-off-by: Ryan Northey <ryan@synca.io> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Sebastian Schepens <sebastian.schepens@mercadolibre.com> Signed-off-by: Ryan Hamilton <rch@google.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sebastian Schepens <sebastian.schepens@mercadolibre.com> Co-authored-by: Ryan Hamilton <rch@google.com> Co-authored-by: Ryan Northey <ryan@synca.io>
solo-io · Mar 8, 2024 · 88883cc · 88883cc
1 parent 7d5050c
commit 88883cc
Show file tree

Hide file tree

Showing 8 changed files with 16 additions and 15 deletions.
diff --git a/VERSION.txt b/VERSION.txt
@@ -1 +1 @@
-1.29.2-dev
+1.29.2
diff --git a/changelogs/current.yaml b/changelogs/current.yaml
@@ -1,25 +1,20 @@
-date: Pending
+date: March 7, 2024
 
 behavior_changes:
-# *Changes that are expected to cause an incompatibility if applicable; deployment changes are likely required*
-
-minor_behavior_changes:
-# *Changes that may cause incompatibilities for some users, but should not for most*
+- area: http2
+  change: |
+    Changes the default value of ``envoy.reloadable_features.http2_use_oghttp2`` to ``false``. This changes the codec used for HTTP/2
+    requests and responses. A number of users have reported issues with oghttp2 including issue 32611 and issue 32401 This behavior
+    can be reverted by setting the feature to ``true``.
 
 bug_fixes:
-# *Changes expected to improve the state of the world and are unlikely to have negative effects*
 - area: jwt_authn
   change: |
     Fixed JWT extractor, which concatenated headers with a comma, resultig in invalid tokens.
 
-removed_config_or_runtime:
-# *Normally occurs at the end of the* :ref:`deprecation period <deprecated>`
-
 new_features:
 - area: google_grpc
   change: |
     Added an off-by-default runtime flag
     ``envoy.reloadable_features.google_grpc_disable_tls_13`` to disable TLSv1.3
     usage by gRPC SDK for ``google_grpc`` services.
-
-deprecated:
diff --git a/ci/Dockerfile-envoy b/ci/Dockerfile-envoy
@@ -58,7 +58,7 @@ COPY --chown=0:0 --chmod=755 \
 
 
 # STAGE: envoy-distroless
-FROM gcr.io/distroless/base-nossl-debian12:nonroot@sha256:51ab103bb161fdf8fee4c6311a2d41f484effc409d4f4c58342ab68b2da7ccc2 AS envoy-distroless
+FROM gcr.io/distroless/base-nossl-debian12:nonroot@sha256:0e777c69ba810353b9f3f2033280bbe7d029d81fa55760f6eec817ef595aa19c AS envoy-distroless
 EXPOSE 10000
 ENTRYPOINT ["/usr/local/bin/envoy"]
 CMD ["-c", "/etc/envoy/envoy.yaml"]

diff --git a/docs/inventories/v1.29/objects.inv b/docs/inventories/v1.29/objects.inv
diff --git a/docs/versions.yaml b/docs/versions.yaml
@@ -22,4 +22,4 @@
 "1.26": 1.26.7
 "1.27": 1.27.3
 "1.28": 1.28.1
-"1.29": 1.29.0
+"1.29": 1.29.1
diff --git a/source/common/runtime/runtime_features.cc b/source/common/runtime/runtime_features.cc
@@ -56,7 +56,6 @@ RUNTIME_GUARD(envoy_reloadable_features_http1_connection_close_header_in_redirec
 RUNTIME_GUARD(envoy_reloadable_features_http1_use_balsa_parser);
 RUNTIME_GUARD(envoy_reloadable_features_http2_decode_metadata_with_quiche);
 RUNTIME_GUARD(envoy_reloadable_features_http2_discard_host_header);
-RUNTIME_GUARD(envoy_reloadable_features_http2_use_oghttp2);
 RUNTIME_GUARD(envoy_reloadable_features_http2_validate_authority_with_quiche);
 RUNTIME_GUARD(envoy_reloadable_features_http_allow_partial_urls_in_referer);
 RUNTIME_GUARD(envoy_reloadable_features_http_filter_avoid_reentrant_local_reply);
@@ -100,6 +99,10 @@ RUNTIME_GUARD(envoy_restart_features_send_goaway_for_premature_rst_streams);
 RUNTIME_GUARD(envoy_restart_features_udp_read_normalize_addresses);
 
 // Begin false flags. These should come with a TODO to flip true.
+
+// TODO(birenroy) Flip this to true after resolving issues.
+// Ignore the automated "remove this flag" issue: we should keep this for 1 year.
+FALSE_RUNTIME_GUARD(envoy_reloadable_features_http2_use_oghttp2);
 // Sentinel and test flag.
 FALSE_RUNTIME_GUARD(envoy_reloadable_features_test_feature_false);
 // TODO(paul-r-gall) Make this enabled by default after additional soak time.

diff --git a/source/extensions/stat_sinks/metrics_service/grpc_metrics_service_impl.cc b/source/extensions/stat_sinks/metrics_service/grpc_metrics_service_impl.cc
@@ -135,6 +135,7 @@ void MetricsFlusher::flushSummary(io::prometheus::client::MetricFamily& metrics_
     quantile->set_value(hist_stats.computedQuantiles()[i]);
   }
   summary->set_sample_count(hist_stats.sampleCount());
+  summary->set_sample_sum(hist_stats.sampleSum());
 }
 
 io::prometheus::client::Metric*

diff --git a/test/extensions/stats_sinks/metrics_service/grpc_metrics_service_impl_test.cc b/test/extensions/stats_sinks/metrics_service/grpc_metrics_service_impl_test.cc
@@ -344,6 +344,7 @@ TEST_F(MetricsServiceSinkTest, HistogramEmitModeBoth) {
 
     const auto& metric1 = (*metrics)[0].metric(0);
     EXPECT_TRUE(metric1.has_summary());
+    EXPECT_TRUE(metric1.summary().has_sample_sum());
     const auto& metric2 = (*metrics)[1].metric(0);
     EXPECT_TRUE(metric2.has_histogram());
   }));
@@ -364,6 +365,7 @@ TEST_F(MetricsServiceSinkTest, HistogramEmitModeSummary) {
 
     const auto& metric1 = (*metrics)[0].metric(0);
     EXPECT_TRUE(metric1.has_summary());
+    EXPECT_TRUE(metric1.summary().has_sample_sum());
   }));
   sink.flush(snapshot_);
 }