Skip to content

Commit

Permalink
fix case where uds assigns capital names (#291)
Browse files Browse the repository at this point in the history
* fix case where uds assigns capital names

Signed-off-by: Scott Weiss <sdw35@cornell.edu>

* one extra line

Signed-off-by: Scott Weiss <sdw35@cornell.edu>
  • Loading branch information
ilackarms authored and yuval-k committed Jan 15, 2019
1 parent 529fe2e commit 6fa21a8
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion projects/gloo/pkg/plugins/kubernetes/uds.go
Expand Up @@ -145,7 +145,7 @@ func createUpstream(writeNamespace string, svc *kubev1.Service, port kubev1.Serv
}
extraLabels[k] = v
}
coremeta.Name = upstreamName(meta.Namespace, meta.Name, port.Port, extraLabels)
coremeta.Name = strings.ToLower(upstreamName(meta.Namespace, meta.Name, port.Port, extraLabels))
coremeta.Namespace = writeNamespace
targetPort := port.TargetPort.IntVal
if targetPort == 0 {
Expand Down
4 changes: 4 additions & 0 deletions projects/hypergloo/main.go
Expand Up @@ -8,6 +8,7 @@ import (
uds "github.com/solo-io/gloo/projects/discovery/pkg/uds/setup"
gatewaysetup "github.com/solo-io/gloo/projects/gateway/pkg/setup"
gloosetup "github.com/solo-io/gloo/projects/gloo/pkg/setup"
ingresssetup "github.com/solo-io/gloo/projects/ingress/pkg/setup"
"github.com/solo-io/solo-kit/pkg/utils/contextutils"
"github.com/solo-io/solo-kit/pkg/utils/log"
"github.com/solo-io/solo-kit/pkg/utils/stats"
Expand All @@ -30,6 +31,9 @@ func run() error {
go func() {
errs <- gatewaysetup.Main()
}()
go func() {
errs <- ingresssetup.Main()
}()
go func() {
errs <- uds.Main()
}()
Expand Down

0 comments on commit 6fa21a8

Please sign in to comment.