Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingress pod stops applying ingress objects once it runs into one that it rejects #3051

Closed
cweidinger opened this issue May 21, 2020 · 0 comments · Fixed by #3053
Closed

Ingress pod stops applying ingress objects once it runs into one that it rejects #3051

cweidinger opened this issue May 21, 2020 · 0 comments · Fixed by #3053
Labels
Type: Bug Something isn't working

Comments

@cweidinger
Copy link

Describe the bug
When Ingress pod finds an ingress object it rejects, it just stops updating ingress proxy config. It should skip over ingress objects it doesn't agree with and keep applying other ingresses.

To Reproduce
0. be using gloo as ingress controller

  1. apply ingress that has servicePort: servicePortName which the ingress pod currently rejects and then an ingress that it shouldn't reject.
    apiVersion: extensions/v1beta1
    kind: Ingress
    metadata:
    name: hc-ingress1
    namespace: default
    spec:
    rules:
  • host: myhost1
    http:
    paths:
    • backend:
      serviceName: myservicename
      servicePort: myserviceportname

apiVersion: extensions/v1beta1
kind: Ingress
metadata:
name: hc-ingress2
namespace: default
spec:
rules:

  • host: myhost2
    http:
    paths:
    • backend:
      serviceName: myservicename
      servicePort: 8080
  1. see that neither ingress was applied to the proxies object
    $ k get proxies -o yaml ingress-proxy -n gloo-admin
  2. See rejection in logs
    $ k logs ingress-6564685644-n6d5k -n gloo-admin | grep rejected
  3. Fix and apply ingress objects
  4. see everything works

Expected behavior
Even if hc-ingress1 fails hc-ingress2 should work but it currently doesn't until hc-ingress1 is fixed. If 1 app team deploys a broken ingress, it shouldn't prevent other app teams from deploying their ingress changes.

Additional context

  • Gloo version 1.3.27
  • Kubernetes version 1.14
@cweidinger cweidinger added the Type: Bug Something isn't working label May 21, 2020
@cweidinger cweidinger changed the title Ingress pod doesn't skip over ingress objects it rejects Ingress pod stops applying ingress objects once it runs into one that it rejects May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant