Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide option for graceful shutdown #3308

Closed
lgadban opened this issue Jul 8, 2020 · 0 comments · Fixed by #3435
Closed

Provide option for graceful shutdown #3308

lgadban opened this issue Jul 8, 2020 · 0 comments · Fixed by #3435
Labels
Type: Enhancement New feature or request

Comments

@lgadban
Copy link
Contributor

lgadban commented Jul 8, 2020

Is your feature request related to a problem? Please describe.
Currently there is no option for a graceful shutdown.
When using "external" mechanisms for health checking (i.e. not relying on Readiness or Endpoints from k8s) there is no way to start failing health checks, gracefully terminate existing connections, prevent new incoming connections, etc.

Describe the solution you'd like
Some combination of scripted health check failures, listener draining, configurable terminationGracePeriodSeconds on the proxy deployment. Ideally exposed by a single helm value (?)

Describe alternatives you've considered
Some of the above mentioned solutions could be implemented after the Gloo installation

Additional context
Similar discussion in #1084
Ideally, with a graceful shutdown, ALBs relying on solely health checking envoy instances can perform e.g. an in-place upgrade with minimal-to-none downtime

@lgadban lgadban added the Type: Enhancement New feature or request label Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant