New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We're leaking the timer we didn't want to leak #4112

Closed

kdorosh opened this issue Jan 14, 2021 · 0 comments · Fixed by #4113

Labels

Type: Bug

Contributor

kdorosh commented Jan 14, 2021

Describe the bug

https://github.com/solo-io/gloo/blob/master/projects/gloo/pkg/plugins/consul/eds.go#L84

is called in a for loop, when it shouldn't be

Expected behavior
Just stop the timer once

kdorosh added the Type: Bug label

solo-changelog-bot bot mentioned this issue

Consul timer leak #4113

Merged

8 tasks

soloio-bulldozer bot closed this as completed in #4113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment