Gloo Fed E2e Test Flake

[ashleywang1]

Describe the bug
When porting the Gloo Fed E2E test over to solo-projects, the test became very flaky:

Summarizing 1 Failure:

[Fail] Failover e2e [It] can failover 
/home/runner/work/solo-projects/solo-projects/projects/gloo-fed/test/e2e/failover_test.go:63

Ran 4 of 4 Specs in 60.263 seconds
FAIL! -- 3 Passed | 1 Failed | 0 Pending | 0 Skipped

Watching the FailoverScheme shows that the status of that CRD changes from

status:
  message: dependent has been updated
  observedGeneration: 1
  processingTime: "2021-01-15T21:20:30.018007400Z"

to

status:
  observedGeneration: 1
  processingTime: "2021-01-15T21:20:31.040989700Z"
  state: ACCEPTED

several times before eventually being ACCEPTED.

We check in the test if the FailoverScheme is ACCEPTED before proceeding, but only once.

[ashleywang1]

A GlooInstance is a 'dependent' of a FailoverScheme object. When it is constantly being updated, the FailoverScheme status flips from Pending to Accepted multiple times until it becomes consistent.

The reason the GlooInstance kept being updated was because the ObjectsEqual function in skv2 was not correct for proto.Messages passed in by value rather than by pointer.

This is being fixed here: solo-io/skv2#200

We will need an skv2 release, and to pick it up in solo-projects