Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for the case where proto.Message types are passed in by value rather than by pointer.
For example:
The upgrade to using gogo/protobufs resulted in several changes around how protos are considered equal.
Previously, we made a change to fix this:
// DeepEqual should be used in place of reflect.DeepEqual when the type of an object is unknown and may be a proto message.
// see golang/protobuf#1173 for details on why reflect.DeepEqual no longer works for proto messages
The way our reconcilers pass in objects into Upsert may result in these items being passed in by value
Solution: be more flexible in the controllerutils.ObjectsEqual, and be able to deal with both cases.
See: gogo/protobuf#476
BOT NOTES:
resolves #199