Disable require_strict_1xx_and_204_response_headers in envoy configuration

[rinormaloku]

Version

No response

Is your feature request related to a problem? Please describe.

When Gloo edge is used alongside the Istio ingress gateway, web socket connections (verified with SignalR 5.x) are rejected with a 502 Bad Gateway, and with the following log in the gateway-proxy:

Error dispatching received data: http/1.1 protocol error: transfer encoding not allowed in 1xx or 204

This happens when a 101 status code is returned to upgrade the connection to web sockets. The istio-ingress gateway adds the following header key=transfer-encoding value=chunked as shown below

[2022-02-22 13:55:50.465][20][trace][http] [external/envoy/source/common/http/http1/codec_impl.cc:499] [C327] 
➥ completed header: key=transfer-encoding value=chunked

Which makes the envoy fail with:

Error dispatching received data: http/1.1 protocol error: transfer encoding not allowed in 1xx or 204

Describe the solution you'd like

Envoy from version 1.15 stopped allowing upstream 1xx or 204 responses with Transfer-Encoding or non-zero Content-Length headers. So now the default is to reject such requests. This however can be reverted by setting the following setting on envoy boostrap configuration to false (the default is true)

envoy.reloadable_features.send_strict_1xx_and_204_response_headers: false

The same is configured in the Istio side: https://github.com/istio/istio/blob/master/pkg/bootstrap/config.go#L282
To resolve those issues: #28433, #36711

Describe alternatives you've considered

No response

Additional Context

We only need to update our helm chart https://github.com/solo-io/gloo/blob/master/install/helm/gloo/templates/12-ingress-proxy-configmap.yaml#L20

To add the following config:

    layered_runtime:
      layers:
      - name: static_layer
        static_layer:
          overload:
            global_downstream_max_connections: 250000
        envoy.reloadable_features.require_strict_1xx_and_204_response_headers: false    # 1
      - name: admin_layer
        admin_layer: {}

1# The change

[Paschi28]

The solution for this issue is to add the config envoy.reloadable_features.require_strict_1xx_and_204_response_headers: false to the helm override values.

Values applied to gloo.gatewayProxies.gatewayProxy.customStaticLayer will add to the corresponding place in the configmap.

@rinormaloku this solves the workaround with adding the setting to the configmap.

[asenyaev]

@Paschi28 @rinormaloku Could you share the helm chart which you use? I cannot find the proper line in values in my chart.

[rinormaloku]

@asenyaev I think Paschi used this property shown in this line: https://github.com/solo-io/gloo/blob/main/install/helm/gloo/templates/12-ingress-proxy-configmap.yaml#L152

It merges the configmap and produces a new value. I haven't stored the values, but you should be able to come up with it with a few tries.

[github-actions]

This issue has been marked as stale because of no activity in the last 180 days. It will be closed in the next 180 days unless it is tagged "no stalebot" or other activity occurs.