Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting HPA autoscaling/v2 #7634

Closed
day0ops opened this issue Jan 6, 2023 · 3 comments · Fixed by #7644
Closed

Supporting HPA autoscaling/v2 #7634

day0ops opened this issue Jan 6, 2023 · 3 comments · Fixed by #7644
Labels
Geo: APAC Type: Enhancement New feature or request

Comments

@day0ops
Copy link
Contributor

day0ops commented Jan 6, 2023

Version

1.12.x (latest stable)

Is your feature request related to a problem? Please describe.

HPA has been graduated to GA and we should use autoscaling/v2 for all the HPAs that we create on Kubernetes v1.23+. This has been widely blogged as well.

This means that when Gloo is deployed with its current HPA on Kubernetes v1.23+, Kubernetes API will upgrade either autoscaling/v1 or autoscaling/v2beta2 automatically to autoscaling/v2. Downside to this is there currently isn't a good set of options to configure HPA for autoscaling/v2 version.

Describe the solution you'd like

Gloo HPA configuration should include support for autoscaling/v2 and various options.

Describe alternatives you've considered

No response

Additional Context

Support matrix already includes Kubernetes 1.23 & 1.24 as supported.

@day0ops day0ops added the Type: Enhancement New feature or request label Jan 6, 2023
@kevin-shelaga
Copy link
Contributor

I could probably add this in fairly quickly, but what fields are missing right now? Metrics and behaviour are both there and available to be defined from what I can see @pseudonator

https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/horizontal-pod-autoscaler-v2/#HorizontalPodAutoscalerSpec

@day0ops
Copy link
Contributor Author

day0ops commented Jan 8, 2023

@kevin-shelaga yup both configs are supported but adding autoscaling/v2 should be suffic at this point. If you don't have any bandwidth let me know I'm happy to raise a PR for this.

In addition IMO we should add a section in this docs page about this so people are aware if they are running in 1.23+ to specify autoscaling/v2 instead.

@kevin-shelaga
Copy link
Contributor

@pseudonator my mistake i misread the template, i see it currently checks for v2beta for those fields. Makes sense now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Geo: APAC Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants