-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for GWP HPA autoscaling/v2 #7644
Add support for GWP HPA autoscaling/v2 #7644
Conversation
Issues linked to changelog: |
Flake? |
I imagine you're referring to the failed upgrade test? If so, #7517 (comment) outlines this. The test is not required since we know it has gaps, so it shouldn't prevent this from merging. |
prepareMakefileFromValuesFile("values/val_gwp_hpa_v2.yaml") | ||
|
||
hpa := makeUnstructured(` | ||
apiVersion: autoscaling/v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: this is an unnecessary amount of yaml
to verify what this PR is setting out to do (verify only GWA HPA autoscaling/v2)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tend to agree, though this seems to mirror existing tests so I don't mind following the pattern
If there are any fields introduced in v2 compared to v2beta2 it would probably be worthwhile to include those
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Back-ports solo-io#7644 to 1.13
Back-ports solo-io#7644 to 1.13
Description
Add support for gateway proxy hpa autoscaling/v2
Context
Fixes: #7634
Checklist:
make -B install-go-tools generated-code
to ensure there will be no code diffBOT NOTES:
resolves #7634