Add support for GWP HPA autoscaling/v2 #7644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues linked to changelog: |
|
Flake? |
I imagine you're referring to the failed upgrade test? If so, #7517 (comment) outlines this. The test is not required since we know it has gaps, so it shouldn't prevent this from merging. |
gunnar-solo
reviewed
Jan 9, 2023
| prepareMakefileFromValuesFile("values/val_gwp_hpa_v2.yaml") | ||
|
|
||
| hpa := makeUnstructured(` | ||
| apiVersion: autoscaling/v2 |
There was a problem hiding this comment.
Nit: this is an unnecessary amount of yaml to verify what this PR is setting out to do (verify only GWA HPA autoscaling/v2)
There was a problem hiding this comment.
Tend to agree, though this seems to mirror existing tests so I don't mind following the pattern
If there are any fields introduced in v2 compared to v2beta2 it would probably be worthwhile to include those
gunnar-solo
approved these changes
Jan 9, 2023
jlourenc
added a commit
to jlourenc/gloo
that referenced
this pull request
Jun 2, 2023
Back-ports solo-io#7644 to 1.13
8 tasks
jlourenc
added a commit
to jlourenc/gloo
that referenced
this pull request
Jun 2, 2023
Back-ports solo-io#7644 to 1.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for gateway proxy hpa autoscaling/v2
Context
Fixes: #7634
Checklist:
make -B install-go-tools generated-codeto ensure there will be no code diffBOT NOTES:
resolves #7634