Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glooctl version improvements #9211

Closed
3 tasks
day0ops opened this issue Mar 2, 2024 · 0 comments · Fixed by #9212
Closed
3 tasks

glooctl version improvements #9211

day0ops opened this issue Mar 2, 2024 · 0 comments · Fixed by #9212
Assignees
Labels
Area: CLI Good First Issue Good issue for newbies Size: S 1 - 3 days Type: Bug Something isn't working

Comments

@day0ops
Copy link
Contributor

day0ops commented Mar 2, 2024

Gloo Edge Product

Enterprise

Gloo Edge Version

1.16.x

Kubernetes Version

1.25.x

Describe the bug

This ticket covers a number of issues and enhancements as laid out below to improve glooctl version

  • incorrect print format for json & yaml when using glooctl version -o xxx. none of variants produce valid output.
  • container image versions are not displayed correctly. container image versions are shown as latest when valid images are used.
  • lack of kubernetes version in output causes some grief when it comes to diagnosing issues.

Expected Behavior

all 3 issues fixed above

Steps to reproduce the bug

run glooctl version -o xxx

Additional Environment Detail

No response

Additional Context

No response

@day0ops day0ops added the Type: Bug Something isn't working label Mar 2, 2024
@day0ops day0ops self-assigned this Mar 2, 2024
day0ops added a commit that referenced this issue Mar 3, 2024
- Added kubernetes version
- Fixed prettifying output
- Fixed image version display

Signed-off-by: pseudonator <kasun.talwatta@gmail.com>
@day0ops day0ops added the Good First Issue Good issue for newbies label Mar 3, 2024
@nfuden nfuden added the Size: S 1 - 3 days label Mar 4, 2024
sam-heilbron added a commit that referenced this issue Mar 21, 2024
* Fixing #9211
- Added kubernetes version
- Fixed prettifying output
- Fixed image version display

Signed-off-by: pseudonator <kasun.talwatta@gmail.com>

* Fixed minor issues when linting checks

Signed-off-by: pseudonator <kasun.talwatta@gmail.com>

* Fixing formatting

Signed-off-by: pseudonator <kasun.talwatta@gmail.com>

* Fixes

Signed-off-by: pseudonator <kasun.talwatta@gmail.com>

* pass kube context

* Update projects/gloo/cli/pkg/cmd/version/cmd.go

Co-authored-by: Jenny Shu <28537278+jenshu@users.noreply.github.com>

* Adding changelog file to new location

* Deleting changelog file from old location

* Adding changelog file to new location

* Deleting changelog file from old location

* Fixes based on PR feedback

Signed-off-by: pseudonator <kasun.talwatta@gmail.com>

* Fixed the changelog based on Sam's feedback

Signed-off-by: pseudonator <kasun.talwatta@gmail.com>

* Minor refactoring

Signed-off-by: pseudonator <kasun.talwatta@gmail.com>

* minor fix

Signed-off-by: pseudonator <kasun.talwatta@gmail.com>

* Adding changelog file to new location

* Deleting changelog file from old location

* Update to remove redundant code

Co-authored-by: Sam Heilbron <SamHeilbron@gmail.com>

* Minor fixes to redundant code

Signed-off-by: pseudonator <kasun.talwatta@gmail.com>

---------

Signed-off-by: pseudonator <kasun.talwatta@gmail.com>
Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
Co-authored-by: Jenny Shu <jenny.shu@solo.io>
Co-authored-by: Jenny Shu <28537278+jenshu@users.noreply.github.com>
Co-authored-by: changelog-bot <changelog-bot>
Co-authored-by: Sam Heilbron <SamHeilbron@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: CLI Good First Issue Good issue for newbies Size: S 1 - 3 days Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants