Expose disableKubernetesDestinations setting as Helm chart value
#2302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues linked to changelog: |
|
Regression test flake /kick |
kdorosh
pushed a commit
that referenced
this pull request
Feb 11, 2020
…2302) * Expose `disableKubernetesDestinations` setting as Helm chart value * Fix Helm unit tests
soloio-bulldozer bot
pushed a commit
that referenced
this pull request
Feb 12, 2020
* Expose `disableKubernetesDestinations` setting as Helm chart value (#2302) * Expose `disableKubernetesDestinations` setting as Helm chart value * Fix Helm unit tests * Move changelog * Update test to respect annotations that still persist on Settings for 1.2.x helm upgrade compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gloo allows you to directly reference a Kubernetes service as a routing destination. To enable this feature, Gloo scans the cluster for Kubernetes services and creates a special type of in-memory Upstream to represent them.
If the cluster contains a lot of services and you do not restrict the namespaces Gloo is watching, this can result in significant overhead. If users do not plan on using this feature, they can now provide a helm value to turn it off.
BOT NOTES:
resolves #2299