Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kind script #279

Merged
merged 2 commits into from Jan 13, 2019
Merged

Add kind script #279

merged 2 commits into from Jan 13, 2019

Conversation

yuval-k
Copy link
Member

@yuval-k yuval-k commented Jan 13, 2019

add a scrip to run tests with kind.
a future PR will introduce this to the build

the main change is to use kubeutil

@yuval-k
Copy link
Member Author

yuval-k commented Jan 13, 2019

the first commit is generated code and toml; so you can focus mostly on the second commit

ilackarms
ilackarms approved these changes Jan 13, 2019
View reviewed changes
Copy link
Member

@ilackarms ilackarms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. @yuval-k would we expect this to run the same in CI?

@yuval-k
Copy link
Member Author

yuval-k commented Jan 13, 2019

yes. my plan is to use this instead of the test cluster.
I want to make sure it works though, so this change doesnt impact the ci timing by much.

@yuval-k yuval-k merged commit bd9ee60 into master Jan 13, 2019
@yuval-k yuval-k deleted the add-kind-script branch January 22, 2019 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilackarms ilackarms ilackarms approved these changes

@rickducott rickducott Awaiting requested review from rickducott

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yuval-k @ilackarms