Ingress: add Envoy host with port rule #3246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gloo in ingress mode adds an Envoy rule that matches a host specified in Ingress, but does not add a rule that matches a host and a port (80 or 443). This creates an issue for proxying GRPC services, because most of the standard GRPC clients (grpcurl, Go, Python) use GRPC endpoint for :authority header, if authority is not explicitly specified. This fixes bug solo-io#3244
|
Waiting for approval from someone in the solo-io org to start testing. |
|
Issues linked to changelog: |
|
/test |
|
/kick mix of valid and invalid virtual services regression test flake https://console.cloud.google.com/cloud-build/builds/a13c32e3-fddf-4263-b28a-e931933d9f87;step=14?project=solo-public opened #3247 to track |
kdorosh
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Gloo in ingress mode should add two Envoy rules: first for the Ingress host, second for the Ingress port and port.
This fixes bug #3244
Context
Gloo in ingress mode adds an Envoy rule that matches a host specified in
Ingress, but does not add a rule that matches a host and a port (80 or
443). This creates an issue for proxying GRPC services, because most of
the standard GRPC clients (grpcurl, Go, Python) use GRPC endpoint for
:authority header, if authority is not explicitly specified.
Checklist:
make update-deps generated-codeto ensure there will be no code diffBOT NOTES:
resolves Ingress controller does not add a rule that matches the host and the port #3244