Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: Ingress: add Envoy host with port rule #3252

Conversation

pbchekin
Copy link
Contributor

Description

Gloo in ingress mode should add two Envoy rules: first for the Ingress host, second for the Ingress port and port.
This fixes bug #3244

Context

Gloo in ingress mode adds an Envoy rule that matches a host specified in
Ingress, but does not add a rule that matches a host and a port (80 or
443). This creates an issue for proxying GRPC services, because most of
the standard GRPC clients (grpcurl, Go, Python) use GRPC endpoint for
:authority header, if authority is not explicitly specified.

Checklist:

  • I included a concise, user-facing changelog (for details, see https://github.com/solo-io/go-utils/tree/master/changelogutils) which references the issue that is resolved.
  • If I updated APIs (our protos) or helm values, I ran make update-deps generated-code to ensure there will be no code diff
  • I followed guidelines laid out in the Gloo contribution guide
  • I opened a draft PR or added the work in progress label if my PR is not ready for review
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Gloo in ingress mode adds an Envoy rule that matches a host specified in
Ingress, but does not add a rule that matches a host and a port (80 or
443). This creates an issue for proxying GRPC services, because most of
the standard GRPC clients (grpcurl, Go, Python) use GRPC endpoint for
:authority header, if authority is not explicitly specified.

This fixes bug solo-io#3244
@solo-build-bot
Copy link

Waiting for approval from someone in the solo-io org to start testing.

@solo-changelog-bot
Copy link

Issues linked to changelog:
#3244

@kdorosh
Copy link
Contributor

kdorosh commented Jun 30, 2020

/test

@soloio-bulldozer soloio-bulldozer bot merged commit 65ee194 into solo-io:v1.4.x Jun 30, 2020
@pbchekin pbchekin deleted the add-ingress-envoy-host-port-rule-backport branch June 30, 2020 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants