Add API for OIDC configuration override in ext-auth #3929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues linked to changelog: |
github-actions
bot
added
the
keep pr updated
sam-heilbron
commented
Nov 30, 2020
sam-heilbron
changed the title
kdorosh
reviewed
Nov 30, 2020
| @@ -546,6 +550,10 @@ message ExtAuthConfig { | |||
| // Configures headers added to requests. | |||
| HeaderConfiguration headers = 10; | |||
|
|
|||
| // OIDC configuration is discovered at <issuerUrl>/.well-known/openid-configuration | |||
| // The configuration override defines any properties that should override this discovery configuration | |||
There was a problem hiding this comment.
an example yaml here in the comments for how the replace would work would be very helpful for users
…io/gloo into ext-ath-oidc-override-config
sam-heilbron
changed the title
kdorosh
reviewed
Dec 1, 2020
Comment on lines
556
to
557
| // ```yaml | ||
| // apiVersion: enterprise.gloo.solo.io/v1 |
kdorosh
approved these changes
Dec 1, 2020
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expose the API to allow users to specify an OIDC configuration override.
Context
OIDC configuration is discovered via the discovery endpoint:
<issuerUrl>/.well-known/openid-configuration. To allow for additional user customization, we expose an override API. Any properties set in this will override the discovered properties.Checklist:
make install-go-tools generated-codeto ensure there will be no code diff