Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove accidental changelog #4122

Merged
merged 4 commits into from
Jan 14, 2021
Merged

Remove accidental changelog #4122

merged 4 commits into from
Jan 14, 2021

Conversation

saiskee
Copy link
Contributor

@saiskee saiskee commented Jan 14, 2021

Description

Remove accidental changelog

Checklist:

  • I included a concise, user-facing changelog (for details, see https://github.com/solo-io/go-utils/tree/master/changelogutils) which references the issue that is resolved.
  • If I updated APIs (our protos) or helm values, I ran make install-go-tools generated-code to ensure there will be no code diff
  • I followed guidelines laid out in the Gloo Edge contribution guide
  • I opened a draft PR or added the work in progress label if my PR is not ready for review
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

saiskee and others added 4 commits December 11, 2020 13:43
@github-actions github-actions bot added the keep pr updated signals bulldozer to keep pr up to date with base branch label Jan 14, 2021
@kdorosh kdorosh merged commit 3a0063d into v1.5.x Jan 14, 2021
@kdorosh kdorosh deleted the remove-accidental-changelog branch January 14, 2021 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants