Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose envoy settings - merge_slashes and normalize_path #5583

Merged
merged 4 commits into from
Nov 17, 2021

Conversation

DoroNahari
Copy link
Contributor

@DoroNahari DoroNahari commented Nov 16, 2021

Description

Please include a summary of the changes.

Expose envoy settings - merge_slashes and normalize_path.
Resolves #5526 #5532

Checklist:

  • I included a concise, user-facing changelog (for details, see https://github.com/solo-io/go-utils/tree/master/changelogutils) which references the issue that is resolved.
  • If I updated APIs (our protos) or helm values, I ran make -B install-go-tools generated-code to ensure there will be no code diff
  • I followed guidelines laid out in the Gloo Edge contribution guide
  • I opened a draft PR or added the work in progress label if my PR is not ready for review
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

BOT NOTES:
resolves #5532
resolves #5526

@DoroNahari DoroNahari requested a review from a team as a code owner November 16, 2021 19:38
@solo-build-bot
Copy link

Waiting for approval from someone in the solo-io org to start testing.

@solo-changelog-bot
Copy link

Issues linked to changelog:
#5532
#5526

@DoroNahari
Copy link
Contributor Author

@sam-heilbron

@sam-heilbron
Copy link
Contributor

sam-heilbron commented Nov 16, 2021

Thanks for the contribution @DoroNahari !

/test

Copy link
Contributor

@ben-taussig-solo ben-taussig-solo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kdorosh
Copy link
Contributor

kdorosh commented Nov 17, 2021

/test

@soloio-bulldozer soloio-bulldozer bot merged commit b6a5e16 into solo-io:master Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose Envoy merge_slashes setting Expose Envoy normalize_path setting
4 participants