second set of knative related fixes #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Marco Schmidt <marcog.schmidt@gmail.com>
ilackarms
force-pushed
the
knative-updates-2
branch
from
1aea926
to
8903d55
Compare
| import ( | ||
| . "github.com/onsi/ginkgo" | ||
| . "github.com/onsi/gomega" | ||
| v1 "github.com/solo-io/gloo/projects/gloo/pkg/api/v1" |
There was a problem hiding this comment.
Nit: clearer aliases, e.g. v1 -> gloov1. Same for kubernetes2 and v12 below
Co-Authored-By: Marco Schmidt <marcog.schmidt@gmail.com>
marcogschmidt
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BOT NOTES:
resolves #657
resolves #779
resolves #790
resolves #789
resolves #788
resolves #787
resolves #679