make secretRef field optional #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues linked to changelog: |
added 11 commits
July 19, 2019 13:50
yuval-k
reviewed
Jul 21, 2019
| @@ -141,6 +144,11 @@ func upstreamInstanceToEndpoint(writeNamespace string, upstream *v1.Upstream, in | |||
| Namespace: writeNamespace, | |||
| }, | |||
| } | |||
| contextutils.LoggerFrom(ctx).Debugw("instance from upstream", | |||
| zap.Any("upstream", upstream), | |||
There was a problem hiding this comment.
nit: zap.Any("upstream", upstream) -> "upstream", upstream
same for below
There was a problem hiding this comment.
Elsewhere we’ve been using zap fields, so I prefer this just for consistency
| By("verifying instance is ready - if this failed, you may need to restart the EC2 instance") | ||
| // stitch the url together to avoid bot spam | ||
| ec2Port := 80 | ||
| ec2Url := fmt.Sprintf("http://%v:%v/metrics", strings.Join([]string{"52", "91", "199", "115"}, "."), ec2Port) |
There was a problem hiding this comment.
that's a dummy ec2 instance for testing
mitchdraft
added
the
work in progress
|
wip: need to add region config for env-derived sessions |
mitchdraft
removed
the
work in progress
|
(no longer a wip) - added region config and tests using local credentials @yuval-k @rickducott |
rickducott
approved these changes
Jul 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BOT NOTES:
resolves #864