Kube services considerations #9194
Conversation
github-actions
bot
added
the
keep pr updated
|
Issues linked to changelog: |
|
/skip-ci |
|
Visit the preview URL for this PR (updated for commit 14e79dc): https://gloo-edge--pr9194-docs-kube-services-n-471835tq.web.app (expires Mon, 04 Mar 2024 19:36:27 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
|
|
||
| {{< highlight yaml "hl_lines=6-10" >}} | ||
| 1. Enable routing to Kubernetes services by setting `settings.disableKubernetesDestinations: true` in your Gloo Edge Helm chart. By default, routing to Kubernetes services is disabled in Gloo Edge due to the negative performance impact on translation and load balancing time in clusters with a lot of Kubernetes services. |
There was a problem hiding this comment.
I find the mixture of positives/negatives a bit confusing in this statement (which to be clear, is more based on the API naming). We are enabling routing to kubernetes services by disabling kubernetes destinations? But the default is also disabled?
What I can't quite tell is should the value be settings.disableKubernetesDestinations=false?
|
|
||
| * `ref` is a {{< protobuf name="core.solo.io.ResourceRef">}} to the service that should receive traffic | ||
| * `port` is an `int` which represents the port on which the service is listening. This must be one of the ports defined in the Kubernetes service spec | ||
| Consider the following information before choosing a Kubernetes service as your routing destination: |
There was a problem hiding this comment.
Given that we don't recommend routing directly to a Kubernetes service, how would I, as an operator of Gloo Edge, route traffic to pods?
There was a problem hiding this comment.
As we have production recommendations, I also think it's helpful if we document that in our kube2e tests. By that I mean, in all of our kube2e tests, we install gloo with some helm values (ie https://github.com/solo-io/gloo/blob/main/test/kube2e/helm/artifacts/helm.yaml), should we set the value (even if it is the default) to the production recommendation?
|
|
||
| {{< highlight yaml "hl_lines=6-10" >}} | ||
| 1. Enable routing to Kubernetes services by setting `settings.disableKubernetesDestinations: true` in your Gloo Edge Helm chart. By default, routing to Kubernetes services is disabled in Gloo Edge due to the negative performance impact on translation and load balancing time in clusters with a lot of Kubernetes services. |
There was a problem hiding this comment.
Should we update https://github.com/solo-io/gloo/blob/main/projects/gloo/api/v1/settings.proto#L676 to both clarify the default value, and perhaps link to this document?
Description
Please include a high level summary of the changes.
This bug fixes ... \ This new feature can be used to ...
Fill out any of the following sections that are relevant and remove the others
API changes
Code changes
Foo()functionBar()functionCI changes
Docs changes
Context
Users ran into this bug doing ... \ Users needed this feature to ...
See slack conversation here
Interesting decisions
We chose to do things this way because ...
Testing steps
I manually verified behavior by ...
Notes for reviewers
Be sure to verify intended behavior by ...
Please proofread comments on ...
This is a complex PR and may require a huddle to discuss ...
Checklist:
BOT NOTES:
resolves #9164