Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc fixes 1.16 #9196

Merged
merged 10 commits into from
Feb 28, 2024
Merged

Doc fixes 1.16 #9196

merged 10 commits into from
Feb 28, 2024

Conversation

Nadine2016
Copy link
Contributor

Description

Please include a high level summary of the changes.

This bug fixes ... \ This new feature can be used to ...

Fill out any of the following sections that are relevant and remove the others

API changes

  • Added x field to y resource
  • ...

Code changes

  • Fix error in Foo() function
  • Add Bar() function
  • ...

CI changes

  • Adjusted schedule for x job
  • ...

Docs changes

  • Added guide about feature x to public docs
  • Updated README to account for y behavior
  • ...

Context

Users ran into this bug doing ... \ Users needed this feature to ...

See slack conversation here

Interesting decisions

We chose to do things this way because ...

Testing steps

I manually verified behavior by ...

Notes for reviewers

Be sure to verify intended behavior by ...

Please proofread comments on ...

This is a complex PR and may require a huddle to discuss ...

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Nadine2016 Nadine2016 requested a review from a team as a code owner February 26, 2024 22:24
@github-actions github-actions bot added the keep pr updated signals bulldozer to keep pr up to date with base branch label Feb 26, 2024
Rachael-Graham
Rachael-Graham previously approved these changes Feb 26, 2024
@solo-changelog-bot
Copy link

Issues linked to changelog:
https://github.com/solo-io/doctopus/issues/79

@soloio-bulldozer soloio-bulldozer bot merged commit 7575d96 into v1.16.x Feb 28, 2024
12 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the doc-fixes-1.16 branch February 28, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants